Skip locking of volumes that are offline

ISCSIConsole/Helpers/LockUtils.cs

@@ -44,10 +44,14 @@ namespace ISCSIConsole
             }
             else if (disk is VolumeDisk)
             {
-                Guid? windowsVolumeGuid = WindowsVolumeHelper.GetWindowsVolumeGuid(((VolumeDisk)disk).Volume);
-                if (windowsVolumeGuid.HasValue)
+                bool skippedLock = (Environment.OSVersion.Version.Major >= 6 && VolumeInfo.IsOffline(((VolumeDisk)disk).Volume));
+                if (!skippedLock)
                 {
-                    WindowsVolumeManager.ReleaseLock(windowsVolumeGuid.Value);
+                    Guid? windowsVolumeGuid = WindowsVolumeHelper.GetWindowsVolumeGuid(((VolumeDisk)disk).Volume);
+                    if (windowsVolumeGuid.HasValue)
+                    {
+                        WindowsVolumeManager.ReleaseLock(windowsVolumeGuid.Value);
+                    }
                 }
             }
 #endif

ISCSIConsole/ISCSIConsole.csproj

@@ -99,6 +99,7 @@
     <Compile Include="Win32\SelectVolumeForm.Designer.cs">
       <DependentUpon>SelectVolumeForm.cs</DependentUpon>
     </Compile>
+    <Compile Include="Win32\VolumeInfo.cs" />
   </ItemGroup>
   <ItemGroup>
     <EmbeddedResource Include="Win32\SelectPhysicalDiskForm.resx">

ISCSIConsole/Win32/SelectVolumeForm.cs

@@ -63,28 +63,32 @@ namespace ISCSIConsole
                 }
                 if (!chkReadOnly.Checked)
                 {
-                    Guid? volumeGuid = WindowsVolumeHelper.GetWindowsVolumeGuid(selectedVolume);
-                    if (Environment.OSVersion.Version.Major >= 6)
+                    bool skipLock = (Environment.OSVersion.Version.Major >= 6 && VolumeInfo.IsOffline(selectedVolume));
+                    if (!skipLock)
                     {
-                        // Windows Vista / 7 enforce various limitations on direct write operations to volumes and disks.
-                        // We either have to take the disk(s) offline or use the OS volume handle for write operations.
-                        if (!volumeGuid.HasValue)
+                        Guid? volumeGuid = WindowsVolumeHelper.GetWindowsVolumeGuid(selectedVolume);
+                        if (Environment.OSVersion.Version.Major >= 6)
                         {
-                            MessageBox.Show("The selected volume is not recognized by your operating system");
-                            return;
+                            // Windows Vista / 7 enforce various limitations on direct write operations to volumes and disks.
+                            // We either have to take the disk(s) offline or use the OS volume handle for write operations.
+                            if (!volumeGuid.HasValue)
+                            {
+                                MessageBox.Show("The selected volume is not recognized by your operating system");
+                                return;
+                            }
+                            selectedVolume = new OperatingSystemVolume(volumeGuid.Value, selectedVolume.BytesPerSector, selectedVolume.Size, chkReadOnly.Checked);
                         }
-                        selectedVolume = new OperatingSystemVolume(volumeGuid.Value, selectedVolume.BytesPerSector, selectedVolume.Size, chkReadOnly.Checked);
-                    }
 
-                    bool isLocked = false;
-                    if (volumeGuid.HasValue)
-                    {
-                        isLocked = WindowsVolumeManager.ExclusiveLock(volumeGuid.Value);
-                    }
-                    if (!isLocked)
-                    {
-                        MessageBox.Show("Unable to lock the volume", "Error");
-                        return;
+                        bool isLocked = false;
+                        if (volumeGuid.HasValue)
+                        {
+                            isLocked = WindowsVolumeManager.ExclusiveLock(volumeGuid.Value);
+                        }
+                        if (!isLocked)
+                        {
+                            MessageBox.Show("Unable to lock the volume", "Error");
+                            return;
+                        }
                     }
                 }
                 m_selectedVolume = selectedVolume;

ISCSIConsole/Win32/VolumeInfo.cs

@@ -0,0 +1,60 @@
+/* Copyright (C) 2016 Tal Aloni <tal.aloni.il@gmail.com>. All rights reserved.
+ * 
+ * You can redistribute this program and/or modify it under the terms of
+ * the GNU Lesser Public License as published by the Free Software Foundation,
+ * either version 3 of the License, or (at your option) any later version.
+ */
+using System;
+using System.Collections.Generic;
+using System.Text;
+using DiskAccessLibrary;
+using DiskAccessLibrary.LogicalDiskManager;
+
+namespace ISCSIConsole
+{
+    public class VolumeInfo
+    {
+        public static bool IsOffline(Volume volume)
+        {
+            IList<PhysicalDisk> disks = GetVolumeDisks(volume);
+            foreach (PhysicalDisk disk in disks)
+            {
+                bool isOnline = disk.GetOnlineStatus();
+                if (isOnline)
+                {
+                    return false;
+                }
+            }
+            return true;
+        }
+
+        private static IList<PhysicalDisk> GetVolumeDisks(Volume volume)
+        {
+            SortedList<int, PhysicalDisk> disks = new SortedList<int, PhysicalDisk>();
+            if (volume is DynamicVolume)
+            {
+                foreach (DiskExtent extent in ((DynamicVolume)volume).Extents)
+                {
+                    if (extent.Disk is PhysicalDisk)
+                    {
+                        PhysicalDisk disk = (PhysicalDisk)extent.Disk;
+                        if (!disks.ContainsKey(disk.PhysicalDiskIndex))
+                        {
+                            disks.Add(disk.PhysicalDiskIndex, disk);
+                        }
+                    }
+                }
+            }
+            else if (volume is Partition)
+            {
+                Partition partition = (Partition)volume;
+                if (partition.Disk is PhysicalDisk)
+                {
+                    PhysicalDisk disk = (PhysicalDisk)partition.Disk;
+                    disks.Add(disk.PhysicalDiskIndex, (PhysicalDisk)disk);
+                }
+            }
+            return disks.Values;
+        }
+    }
+}